Reviewed-by: Christian König <christian.koenig@xxxxxxx>
Am 09.08.19 um 12:28 schrieb Zhang, Hawking:
> Reviewed-by: Hawking Zhang <Hawking.Zhang@xxxxxxx>
>
> Regards,
> Hawking
>
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Tao Zhou
> Sent: 2019年8月9日 17:51
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx; Koenig, Christian <Christian.Koenig@xxxxxxx>; Zhang, Hawking <Hawking.Zhang@xxxxxxx>; Freehill, Chris <Chris.Freehill@xxxxxxx>; Russell, Kent <Kent.Russell@xxxxxxx>
> Cc: Zhou1, Tao <Tao.Zhou1@xxxxxxx>
> Subject: [PATCH] drm/amdgpu: remove ras block's feature status info in sysfs
>
> feature mask info is enough for rocm tool, "cat /sys/class/drm/card0/device/ras/features" will get the info like this:
>
> feature mask: 0x3ffb
>
> Signed-off-by: Tao Zhou <tao.zhou1@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 19 +------------------
> 1 file changed, 1 insertion(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index be59102526a1..50c13b02d234 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -791,25 +791,8 @@ static ssize_t amdgpu_ras_sysfs_features_read(struct device *dev, {
> struct amdgpu_ras *con =
> container_of(attr, struct amdgpu_ras, features_attr);
> - struct drm_device *ddev = dev_get_drvdata(dev);
> - struct amdgpu_device *adev = ddev->dev_private;
> - struct ras_common_if head;
> - int ras_block_count = AMDGPU_RAS_BLOCK_COUNT;
> - int i, enabled;
> - ssize_t s;
> -
> - s = scnprintf(buf, PAGE_SIZE, "feature mask: 0x%x\n", con->features);
> -
> - for (i = 0; i < ras_block_count; i++) {
> - head.block = i;
> - enabled = amdgpu_ras_is_feature_enabled(adev, &head);
> -
> - s += scnprintf(&buf[s], PAGE_SIZE - s,
> - "%s ras feature mask: %s\n",
> - ras_block_str(i), enabled?"on":"off");
> - }
>
> - return s;
> + return scnprintf(buf, PAGE_SIZE, "feature mask: 0x%x\n",
> +con->features);
> }
>
> static int amdgpu_ras_sysfs_create_feature_node(struct amdgpu_device *adev)
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
