Hi Tejun,
Thanks for comments. I can definitely add more documentation but just need a bit of clarification on this.
1). Documentation for user on how to use device cgroup for amdkfd device. I have some more information on this in patch 4.
or
2) The reason devcgroup_check_permission() needs to be exported
or
3) something else totally that I missed.
Best Regards,
Harish
From: Tejun Heo <htejun@xxxxxxxxx> on behalf of Tejun Heo <tj@xxxxxxxxxx>
Sent: Friday, May 17, 2019 12:49 PM
To: Kasiviswanathan, Harish
Cc: cgroups@xxxxxxxxxxxxxxx; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
Subject: Re: [PATCH v2 0/4] AMDKFD (AMD GPU compute) support for device cgroup.
[CAUTION: External Email]
On Fri, May 17, 2019 at 04:14:52PM +0000, Kasiviswanathan, Harish wrote:
> amdkfd (part of amdgpu) driver supports the AMD GPU compute stack.
> amdkfd exposes only a single device /dev/kfd even if multiple AMD GPU
> (compute) devices exist in a system. However, amdgpu drvier exposes a
> separate render device file /dev/dri/renderDN for each device. To participate
> in device cgroup amdkfd driver will rely on these redner device files.
>
> v2: Exporting devcgroup_check_permission() instead of
> __devcgroup_check_permission() as per review comments.
Looks fine to me but given how non-obvious it is, some documentation
would be great.
Thanks.
--
tejun
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
