Re: [PATCH] drm/amdgpu: use div64_ul for 32-bit compatibility v1

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 17, 2019 at 2:34 PM Abramov, Slava <Slava.Abramov@xxxxxxx> wrote:
>
> v1: replace casting to unsigned long with div64_ul
>
> Change-Id: Ia48671ed0756bb73c7b4760a800bcb6f600cbef2
> Signed-off-by: Slava Abramov <slava.abramov@xxxxxxx>

Acked-by: Alex Deucher <alexander.deucher@xxxxxxx>

> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index da1dc40b9b14..d5719b0fb82c 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -764,8 +764,8 @@ static ssize_t amdgpu_ras_sysfs_badpages_read(struct file *f,
>   struct amdgpu_device *adev = con->adev;
>   const unsigned int element_size =
>   sizeof("0xabcdabcd : 0x12345678 : R\n") - 1;
> - unsigned int start = (ppos + element_size - 1) / element_size;
> - unsigned int end = (ppos + count - 1) / element_size;
> + unsigned int start = div64_ul(ppos + element_size - 1, element_size);
> + unsigned int end = div64_ul(ppos + count - 1, element_size);
>   ssize_t s = 0;
>   struct ras_badpage *bps = NULL;
>   unsigned int bps_count = 0;
> --
> 2.17.1
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
_______________________________________________
amd-gfx mailing list
amd-gfx@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/amd-gfx




[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux