Hi Alex Sure, I will send out V2 with the fix. thanks! James Zhu On 2018-08-09 11:48 AM, Alex Deucher wrote: > On Thu, Aug 9, 2018 at 11:41 AM, James Zhu <jzhums at gmail.com> wrote: >> Signed-off-by: James Zhu <James.Zhu at amd.com> > Please include a commit message. E.g., > Track the TMR address for VCN PSP firmware loading. > > With that added: > Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > >> --- >> drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h >> index 08e3857..edb7baf 100644 >> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h >> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ucode.h >> @@ -226,6 +226,9 @@ struct amdgpu_firmware_info { >> void *kaddr; >> /* ucode_size_bytes */ >> uint32_t ucode_size; >> + /* starting tmr mc address */ >> + uint32_t tmr_mc_addr_lo; >> + uint32_t tmr_mc_addr_hi; >> }; >> >> void amdgpu_ucode_print_mc_hdr(const struct common_firmware_header *hdr); >> -- >> 2.7.4 >> >> _______________________________________________ >> amd-gfx mailing list >> amd-gfx at lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/amd-gfx