On 08/02/2018 10:55 PM, Michel Dänzer wrote: > On 2018-08-02 04:04 PM, Christian König wrote: >> This way we can always find a BO structure by its handle. >> >> Signed-off-by: Christian König <christian.koenig at amd.com> > > Typo in the shortlog: should be "lookup" instead of "lockup". > > Also, this patch should really be after patch 4. > > >> @@ -240,14 +237,11 @@ int amdgpu_bo_export(amdgpu_bo_handle bo, >> return 0; >> >> case amdgpu_bo_handle_type_kms: >> - amdgpu_add_handle_to_table(bo); >> - /* fall through */ >> case amdgpu_bo_handle_type_kms_noimport: >> *shared_handle = bo->handle; >> return 0; > > This is a bit unfortunate, amdgpu_bo_handle_type_kms_noimport only just > landed this week for the 2.4.93 release, now it'll already be useless > noise... A bit more coordination would have been nice. :) BTW, there is a schedule for that release? I mean if amdgpu_bo_handle_type_kms_noimport is merged in the release at last minute. Generally we may wait for some verification or process for a release. if the func has to go through a verification/process, that maybe not happen in a week. Jerry > > > Anyway, with the typo in patch 3 fixed, patches 2 & 4-6 are > > Reviewed-by: Michel Dänzer <michel.daenzer at amd.com> > >
