[PATCH libdrm 1/6] amdgpu: always add all BOs to lockup table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-08-02 04:04 PM, Christian König wrote:
> This way we can always find a BO structure by its handle.
> 
> Signed-off-by: Christian König <christian.koenig at amd.com>

Typo in the shortlog: should be "lookup" instead of "lockup".

Also, this patch should really be after patch 4.


> @@ -240,14 +237,11 @@ int amdgpu_bo_export(amdgpu_bo_handle bo,
>  		return 0;
>  
>  	case amdgpu_bo_handle_type_kms:
> -		amdgpu_add_handle_to_table(bo);
> -		/* fall through */
>  	case amdgpu_bo_handle_type_kms_noimport:
>  		*shared_handle = bo->handle;
>  		return 0;

This is a bit unfortunate, amdgpu_bo_handle_type_kms_noimport only just
landed this week for the 2.4.93 release, now it'll already be useless
noise... A bit more coordination would have been nice. :)


Anyway, with the typo in patch 3 fixed, patches 2 & 4-6 are

Reviewed-by: Michel Dänzer <michel.daenzer at amd.com>


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux