On 08/02/2018 03:38 PM, Harry Wentland wrote: > [Why] > VGA sometimes has trouble retrieving the EDID on very long cables, KVM > switches, or old displays. > > [How] > Only require EDID read for HDMI and DVI and exempt other types (DP, > VGA). We currently don't support VGA but if anyone adds support in the > future this might get overlooked. > > Signed-off-by: Harry Wentland <harry.wentland at amd.com> > Suggested-by: Michel Dänzer <michel at daenzer.net> > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link.c b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > index d6086c591f75..71b94e3b472e 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c > @@ -753,7 +753,8 @@ bool dc_link_detect(struct dc_link *link, enum dc_detect_reason reason) > * even if we have no EDID in order to go to > * fail-safe mode > */ > - if (!dc_is_dp_signal(link->connector_signal)) > + if (dc_is_hdmi_signal(link->connector_signal) || > + dc_is_dvi_signal(link->connector_signal)) > return false; > default: > break; > Looks good. Fixing the indenting or merging the conditions would be a good idea, however. Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>
