On 2018-07-17 05:10 PM, Harry Wentland wrote: > On 2018-07-17 10:17 AM, Michel Dänzer wrote: >> On 2018-07-17 03:29 PM, sunpeng.li at amd.com wrote: >>> From: Mikita Lipski <mikita.lipski at amd.com> >>> >>> [why] >>> The warning message floods the dmesg log on Tonga even >>> though it is expected to have a pix_clk set to zero, >>> when there is no display connected. >>> [how] >>> remove the assert >>> >>> Change-Id: I4ca1e42439369b2305694b403457b5de60fc4ab1 >>> Signed-off-by: Mikita Lipski <mikita.lipski at amd.com> >>> Reviewed-by: Harry Wentland <Harry.Wentland at amd.com> >>> Acked-by: Leo Li <sunpeng.li at amd.com> >>> --- >>> drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c | 4 ---- >>> 1 file changed, 4 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c >>> index ec32213..74c05e8 100644 >>> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c >>> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c >>> @@ -149,10 +149,6 @@ static uint32_t get_max_pixel_clock_for_all_paths( >>> max_pix_clk = >>> pipe_ctx->stream_res.pix_clk_params.requested_pix_clk; >>> } >>> - >>> - if (max_pix_clk == 0) >>> - ASSERT(0); >>> - >>> return max_pix_clk; >>> } >>> >>> >> >> On my development system, max_pix_clk == 0 even though there's a display >> connected via HDMI. Is that expected as well? >> > > It's not really expected. Does it happen on mode set, hotplug, randomly? Seems to happen when the display is turned off, e.g. via DPMS. > Do you have a stack trace? Yep, attached. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer -------------- next part -------------- [ 2367.329074] WARNING: CPU: 8 PID: 16019 at drivers/gpu/drm//amd/amdgpu/../display/dc/dce100/dce100_hw_sequencer.c:154 dce100_set_bandwidth+0x154/0x300 [amdgpu] [ 2367.329086] Modules linked in: lz4(E) lz4_compress(E) cpufreq_powersave(E) cpufreq_userspace(E) cpufreq_conservative(E) binfmt_misc(E) nls_ascii(E) nls_cp437(E) vfat(E) edac_mce_amd(E) fat(E) amdkfd(OE) kvm(E) irqbypass(E) crct10dif_pclmul(E) crc32_pclmul(E) ghash_clmulni_intel(E) pcbc(E) radeon(OE) wmi_bmof(E) amdgpu(OE) snd_hda_codec_realtek(E) snd_hda_codec_generic(E) chash(OE) gpu_sched(OE) snd_hda_codec_hdmi(E) ttm(OE) aesni_intel(E) aes_x86_64(E) crypto_simd(E) drm_kms_helper(OE) cryptd(E) snd_hda_intel(E) efi_pstore(E) glue_helper(E) r8169(E) pcspkr(E) snd_hda_codec(E) drm(OE) mii(E) snd_hda_core(E) efivars(E) sg(E) i2c_algo_bit(E) snd_hwdep(E) fb_sys_fops(E) syscopyarea(E) snd_pcm(E) sysfillrect(E) sp5100_tco(E) snd_timer(E) sysimgblt(E) i2c_piix4(E) k10temp(E) wmi(E) ccp(E) snd(E) soundcore(E) [ 2367.329232] rng_core(E) button(E) acpi_cpufreq(E) tcp_bbr(E) sch_fq(E) nct6775(E) hwmon_vid(E) sunrpc(E) efivarfs(E) ip_tables(E) x_tables(E) ext4(E) crc32c_generic(E) crc16(E) mbcache(E) jbd2(E) fscrypto(E) dm_mod(E) raid10(E) raid1(E) raid0(E) multipath(E) linear(E) md_mod(E) sd_mod(E) evdev(E) hid_generic(E) usbhid(E) hid(E) ahci(E) xhci_pci(E) libahci(E) xhci_hcd(E) libata(E) crc32c_intel(E) usbcore(E) scsi_mod(E) gpio_amdpt(E) gpio_generic(E) [ 2367.329337] CPU: 8 PID: 16019 Comm: Xorg Tainted: G W OE 4.18.0-rc1+ #110 [ 2367.329344] Hardware name: Micro-Star International Co., Ltd. MS-7A34/B350 TOMAHAWK (MS-7A34), BIOS 1.80 09/13/2017 [ 2367.329532] RIP: 0010:dce100_set_bandwidth+0x154/0x300 [amdgpu] [ 2367.329538] Code: 84 c0 74 08 3c 03 0f 8e 7d 01 00 00 8b 83 10 01 00 00 41 39 c6 44 0f 42 f0 48 81 c3 30 04 00 00 48 39 d3 75 90 45 85 f6 75 02 <0f> 0b 49 8d 9d 48 01 00 00 48 b8 00 00 00 00 00 fc ff df 44 89 74 [ 2367.329663] RSP: 0018:ffff88028cc2f338 EFLAGS: 00010246 [ 2367.329672] RAX: 1ffff1007b1652d0 RBX: ffff8803d8b29ab0 RCX: 0000000000000000 [ 2367.329678] RDX: ffff8803d8b29ab0 RSI: 0000000000000000 RDI: ffff8803d8b29c5c [ 2367.329684] RBP: dffffc0000000000 R08: ffffed007a55d632 R09: ffffed007a55d632 [ 2367.329690] R10: ffff88028cc2f140 R11: ffffed007a55d631 R12: 1ffff10051985e69 [ 2367.329695] R13: ffff8803c8bee600 R14: 0000000000000000 R15: ffff8803d8b28000 [ 2367.329703] FS: 00007f3ad605f940(0000) GS:ffff8803ee200000(0000) knlGS:0000000000000000 [ 2367.329709] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 [ 2367.329714] CR2: 000055720e2bb560 CR3: 00000003c1418000 CR4: 00000000003406e0 [ 2367.329720] Call Trace: [ 2367.329882] ? dce100_pplib_apply_display_requirements+0x1b0/0x1b0 [amdgpu] [ 2367.330041] ? bios_is_accelerated_mode+0xdb/0x140 [amdgpu] [ 2367.330201] dc_commit_state+0xd1e/0x1520 [amdgpu] [ 2367.330364] ? dc_destroy+0x90/0x90 [amdgpu] [ 2367.330403] ? drm_dev_dbg+0x1a0/0x1a0 [drm] [ 2367.330571] amdgpu_dm_atomic_commit_tail+0x968/0x3fa0 [amdgpu] [ 2367.330592] ? do_raw_spin_unlock+0x54/0x220 [ 2367.330602] ? _raw_spin_unlock_irq+0x29/0x40 [ 2367.330751] ? amdgpu_dm_do_flip+0xab0/0xab0 [amdgpu] [ 2367.330774] ? drm_atomic_helper_swap_state+0x7a2/0x15b0 [drm_kms_helper] [ 2367.330784] ? wait_for_completion_io_timeout+0x390/0x390 [ 2367.330793] ? lock_downgrade+0x5e0/0x5e0 [ 2367.330815] ? drm_atomic_helper_swap_state+0x6b5/0x15b0 [drm_kms_helper] [ 2367.330964] ? dm_plane_helper_prepare_fb+0x291/0xb00 [amdgpu] [ 2367.330990] ? drm_atomic_helper_wait_for_dependencies+0x3ee/0x7d0 [drm_kms_helper] [ 2367.331017] commit_tail+0x9a/0xf0 [drm_kms_helper] [ 2367.331041] drm_atomic_helper_commit+0x179/0x240 [drm_kms_helper] [ 2367.331086] drm_atomic_connector_commit_dpms+0x311/0x490 [drm] [ 2367.331097] ? ww_mutex_lock+0x34/0xa0 [ 2367.331138] ? drm_modeset_backoff+0x1b1/0x4f0 [drm] [ 2367.331181] set_property_atomic+0x1ad/0x2b0 [drm] [ 2367.331224] ? drm_object_property_get_value+0xf0/0xf0 [drm] [ 2367.331277] drm_mode_obj_set_property_ioctl+0x371/0x590 [drm] [ 2367.331318] ? drm_mode_obj_find_prop_id+0x180/0x180 [drm] [ 2367.331362] ? drm_mode_connector_set_obj_prop+0x150/0x150 [drm] [ 2367.331401] drm_mode_connector_property_set_ioctl+0xe8/0x170 [drm] [ 2367.331441] ? drm_mode_connector_set_obj_prop+0x150/0x150 [drm] [ 2367.331475] ? drm_is_current_master+0x5f/0x110 [drm] [ 2367.331510] ? drm_ioctl_permit+0x148/0x190 [drm] [ 2367.331545] drm_ioctl_kernel+0x197/0x220 [drm] [ 2367.331582] ? drm_setversion+0x7d0/0x7d0 [drm] [ 2367.331594] ? __check_object_size+0x149/0x360 [ 2367.331631] drm_ioctl+0x60a/0x970 [drm] [ 2367.331672] ? drm_mode_connector_set_obj_prop+0x150/0x150 [drm] [ 2367.331708] ? drm_ioctl_kernel+0x220/0x220 [drm] [ 2367.331723] ? lock_downgrade+0x5e0/0x5e0 [ 2367.331732] ? __pm_runtime_resume+0x79/0x100 [ 2367.331742] ? debug_check_no_locks_freed+0x2c0/0x2c0 [ 2367.331751] ? do_raw_spin_unlock+0x54/0x220 [ 2367.331867] amdgpu_drm_ioctl+0xcc/0x1a0 [amdgpu] [ 2367.331880] do_vfs_ioctl+0x192/0xf30 [ 2367.331889] ? __kasan_slab_free+0x145/0x180 [ 2367.331899] ? ioctl_preallocate+0x1b0/0x1b0 [ 2367.331909] ? __fget+0x1c8/0x300 [ 2367.331919] ? lock_downgrade+0x5e0/0x5e0 [ 2367.331927] ? __fget+0x49/0x300 [ 2367.331940] ? __fget+0x1e0/0x300 [ 2367.331955] ksys_ioctl+0x70/0x80 [ 2367.331966] __x64_sys_ioctl+0x6f/0xb0 [ 2367.331975] do_syscall_64+0xa5/0x3f0 [ 2367.331985] entry_SYSCALL_64_after_hwframe+0x49/0xbe [ 2367.331994] RIP: 0033:0x7f3ad700c097 [ 2367.331998] Code: b3 66 90 48 8b 05 f1 7d 0c 00 64 c7 00 26 00 00 00 48 c7 c0 ff ff ff ff c3 66 2e 0f 1f 84 00 00 00 00 00 b8 10 00 00 00 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 8b 0d c1 7d 0c 00 f7 d8 64 89 01 48 [ 2367.332123] RSP: 002b:00007fff0a5fe478 EFLAGS: 00000246 ORIG_RAX: 0000000000000010 [ 2367.332133] RAX: ffffffffffffffda RBX: 0000000000000003 RCX: 00007f3ad700c097 [ 2367.332139] RDX: 00007fff0a5fe4b0 RSI: 00000000c01064ab RDI: 000000000000000d [ 2367.332144] RBP: 00007fff0a5fe4a0 R08: 00007fff0a5fe438 R09: 00007fff0a5fe434 [ 2367.332150] R10: 00007fff0a5fe340 R11: 0000000000000246 R12: 00007fff0a5fe4b0 [ 2367.332156] R13: 00000000c01064ab R14: 000000000000000d R15: 000055720f3058f0 [ 2367.332171] irq event stamp: 0 [ 2367.332178] hardirqs last enabled at (0): [<0000000000000000>] (null) [ 2367.332189] hardirqs last disabled at (0): [<ffffffff8411642c>] copy_process.part.32+0x109c/0x60d0 [ 2367.332198] softirqs last enabled at (0): [<ffffffff841164ca>] copy_process.part.32+0x113a/0x60d0 [ 2367.332204] softirqs last disabled at (0): [<0000000000000000>] (null)
