[PATCH 1/7] drm/amd/display: Remove unnecessary warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018-07-17 03:29 PM, sunpeng.li at amd.com wrote:
> From: Mikita Lipski <mikita.lipski at amd.com>
> 
> [why]
> The warning message floods the dmesg log on Tonga even
> though it is expected to have a pix_clk set to zero,
> when there is no display connected.
> [how]
> remove the assert
> 
> Change-Id: I4ca1e42439369b2305694b403457b5de60fc4ab1
> Signed-off-by: Mikita Lipski <mikita.lipski at amd.com>
> Reviewed-by: Harry Wentland <Harry.Wentland at amd.com>
> Acked-by: Leo Li <sunpeng.li at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c
> index ec32213..74c05e8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce100/dce100_hw_sequencer.c
> @@ -149,10 +149,6 @@ static uint32_t get_max_pixel_clock_for_all_paths(
>  			max_pix_clk =
>  				pipe_ctx->stream_res.pix_clk_params.requested_pix_clk;
>  	}
> -
> -	if (max_pix_clk == 0)
> -		ASSERT(0);
> -
>  	return max_pix_clk;
>  }
>  
> 

On my development system, max_pix_clk == 0 even though there's a display
connected via HDMI. Is that expected as well?


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux