I wonder how '#if 0' made its way upstream, but besides this Reviewed-by: Slava Abramov <slava.abramov at amd.com> ________________________________ From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of Michel Dänzer <michel at daenzer.net> Sent: Wednesday, June 27, 2018 12:39:40 PM To: amd-gfx at lists.freedesktop.org Subject: [PATCH xf86-video-amdgpu 1/2] Remove #if 0'd code From: Michel Dänzer <michel.daenzer@xxxxxxx> This has always been disabled, no need to keep it. Signed-off-by: Michel Dänzer <michel.daenzer at amd.com> --- src/drmmode_display.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/drmmode_display.c b/src/drmmode_display.c index 1563417a7..5fe49b607 100644 --- a/src/drmmode_display.c +++ b/src/drmmode_display.c @@ -2459,15 +2459,6 @@ static const xf86OutputFuncsRec drmmode_output_funcs = { .create_resources = drmmode_output_create_resources, .set_property = drmmode_output_set_property, .get_property = drmmode_output_get_property, -#if 0 - - .save = drmmode_crt_save, - .restore = drmmode_crt_restore, - .mode_fixup = drmmode_crt_mode_fixup, - .prepare = drmmode_output_prepare, - .mode_set = drmmode_crt_mode_set, - .commit = drmmode_output_commit, -#endif .detect = drmmode_output_detect, .mode_valid = drmmode_output_mode_valid, @@ -3470,9 +3461,6 @@ Bool drmmode_setup_colormap(ScreenPtr pScreen, ScrnInfoPtr pScrn) !xf86HandleColormaps(pScreen, 256, 10, NULL, NULL, CMAP_PALETTED_TRUECOLOR -#if 0 /* This option messes up text mode! (eich at suse.de) */ - | CMAP_LOAD_EVEN_IF_OFFSCREEN -#endif | CMAP_RELOAD_ON_MODE_SWITCH)) return FALSE; } -- 2.18.0 _______________________________________________ amd-gfx mailing list amd-gfx at lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/amd-gfx -------------- next part -------------- An HTML attachment was scrubbed... URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20180627/81de2322/attachment-0001.html>