On 06/26/2018 04:35 PM, Michel Dänzer wrote: > On 2018-06-26 10:28 AM, Zhang, Jerry (Junwei) wrote: >> On 06/26/2018 03:46 PM, Michel Dänzer wrote: >>> On 2018-06-26 08:00 AM, Junwei Zhang wrote: >>>> It could be got by amdgpu_bo_gpu_offset() if need >>>> >>>> Signed-off-by: Junwei Zhang <Jerry.Zhang at amd.com> >>>> >>>> [...] >>>> >>>> @@ -931,7 +928,6 @@ int amdgpu_bo_pin_restricted(struct amdgpu_bo >>>> *bo, u32 domain, >>>> * amdgpu_bo_pin - pin an &amdgpu_bo buffer object >>>> * @bo: &amdgpu_bo buffer object to be pinned >>>> * @domain: domain to be pinned to >>>> - * @gpu_addr: GPU offset of the &amdgpu_bo buffer object >>>> * >>>> * A simple wrapper to amdgpu_bo_pin_restricted(). >>>> * Provides a simpler API for buffers that do not have any strict >>>> restrictions >>> >>> This also needs to be removed in the comment before >>> amdgpu_bo_pin_restricted. With that fixed, >> >> Exactly, I will. > > Thanks. FWIW, running e.g. > > make -j$(nproc) htmldocs Thanks for your sharing useful command :) Jerry > > should have produced the following warning: > > ./drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:841: warning: Excess > function parameter 'gpu_addr' description in 'amdgpu_bo_pin_restricted' > >
