On Fri, Feb 9, 2018 at 3:12 PM, Matthias Kaehlcke <mka at chromium.org> wrote: > The initialization of 'result' is unnecessary, the variable is assigned > unconditionally a few lines below. Removing the initialization also fixes > the following warning when building with clang: > > drivers/gpu/drm/amd/amdgpu/../display/dc/core/dc_link_dp.c:1931:26: > error: implicit conversion from enumeration type 'enum ddc_result' > to different enumeration type 'enum dc_status' [-Werror,-Wenum-conversion] > enum dc_status result = DDC_RESULT_UNKNOWN; > > Signed-off-by: Matthias Kaehlcke <mka at chromium.org> Reviewed-by: Guenter Roeck <groeck at chromium.org> > --- > drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > index 4ee4c03a6724..8e3a8c1395a3 100644 > --- a/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > +++ b/drivers/gpu/drm/amd/display/dc/core/dc_link_dp.c > @@ -1926,7 +1926,7 @@ bool dc_link_handle_hpd_rx_irq(struct dc_link *link, union hpd_irq_data *out_hpd > { > union hpd_irq_data hpd_irq_dpcd_data = {{{{0}}}}; > union device_service_irq device_service_clear = { { 0 } }; > - enum dc_status result = DDC_RESULT_UNKNOWN; > + enum dc_status result; > bool status = false; > /* For use cases related to down stream connection status change, > * PSR and device auto test, refer to function handle_sst_hpd_irq > -- > 2.16.0.rc1.238.g530d649a79-goog >