[PATCH 1/7] drm/amd/powerplay: correct PP_TemperatureRange member type since negative values are part of the valid range

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jan 2, 2018 at 10:15 PM, Evan Quan <evan.quan at amd.com> wrote:
> Change-Id: I68bb53691fb2edca66c09391ab5e60357496283c
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c   | 4 ++--
>  drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c | 4 ++--
>  drivers/gpu/drm/amd/powerplay/inc/power_state.h      | 4 ++--
>  3 files changed, 6 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c
> index d7aa643..f6573ed 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_thermal.c
> @@ -310,9 +310,9 @@ int smu7_thermal_get_temperature(struct pp_hwmgr *hwmgr)
>  static int smu7_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,
>                 uint32_t low_temp, uint32_t high_temp)
>  {
> -       uint32_t low = SMU7_THERMAL_MINIMUM_ALERT_TEMP *
> +       int low = SMU7_THERMAL_MINIMUM_ALERT_TEMP *
>                         PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
> -       uint32_t high = SMU7_THERMAL_MAXIMUM_ALERT_TEMP *
> +       int high = SMU7_THERMAL_MAXIMUM_ALERT_TEMP *
>                         PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
>
>         if (low < low_temp)
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
> index dc3761b..7491163 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_thermal.c
> @@ -386,9 +386,9 @@ int vega10_thermal_get_temperature(struct pp_hwmgr *hwmgr)
>  static int vega10_thermal_set_temperature_range(struct pp_hwmgr *hwmgr,
>                 struct PP_TemperatureRange *range)
>  {
> -       uint32_t low = VEGA10_THERMAL_MINIMUM_ALERT_TEMP *
> +       int low = VEGA10_THERMAL_MINIMUM_ALERT_TEMP *
>                         PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
> -       uint32_t high = VEGA10_THERMAL_MAXIMUM_ALERT_TEMP *
> +       int high = VEGA10_THERMAL_MAXIMUM_ALERT_TEMP *
>                         PP_TEMPERATURE_UNITS_PER_CENTIGRADES;
>         uint32_t val, reg;
>
> diff --git a/drivers/gpu/drm/amd/powerplay/inc/power_state.h b/drivers/gpu/drm/amd/powerplay/inc/power_state.h
> index 827860f..a99b5cbb 100644
> --- a/drivers/gpu/drm/amd/powerplay/inc/power_state.h
> +++ b/drivers/gpu/drm/amd/powerplay/inc/power_state.h
> @@ -122,8 +122,8 @@ struct PP_StateSoftwareAlgorithmBlock {
>   * Type to hold a temperature range.
>   */
>  struct PP_TemperatureRange {
> -       uint32_t min;
> -       uint32_t max;
> +       int min;
> +       int max;
>  };
>
>  struct PP_StateValidationBlock {
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux