On 2017-12-27 04:04 AM, Michel Dänzer wrote:
> On 2017-12-27 05:43 AM, Dieter Nützel wrote:
>> Hello AMD team,
>>
>> I got this since latest 'amd-staging-drm-next' git update
>> (#b956c586e58a) during boot with Polaris RX580 DC on:
>>
>> [Â Â Â 3.586342] [drm:dal_bios_parser_init_cmd_tbl [amdgpu]] *ERROR* Don't
>> have enable_spread_spectrum_on_ppll for v4
>> [Â Â Â 3.586410] [drm:dal_bios_parser_init_cmd_tbl [amdgpu]] *ERROR* Don't
>> have program_clock for v7
>>
>> Latest GOOD commit was #b341a19e8039 (drm/radeon: Remove
>> KFD_CIK_SDMA_QUEUE_OFFSET).
>>
>> I'll bisect if I have some time.
>> Maybe someone send a hint to the right commit.
>
> I don't think bisecting is useful, it'll most likely just identify
> commit 040dda2e1f52 ("drm/amd/display: Error print when ATOM BIOS
> implementation is missing") which started printing these messages for
> missing ATOM BIOS implementations.
>
> I'm not sure, but I suspect these messages are harmless, given that
> things are otherwise presumably still working as well as they were before.
These are harmless. I wrongfully assumed that printing errors here should be fine on all ASICs as I assumed all relevant functions were implemented. Apparently they're not, proving me wrong and proving the usefulness of some sort of print here. I'll send a patch to demote the prints to debug level.
Harry
>
>
