On 2017-10-26 02:56 PM, Andrey Grodzovsky wrote: > > > On 2017-10-26 02:43 PM, Christian König wrote: >> Am 26.10.2017 um 19:56 schrieb Deucher, Alexander: >>>> -----Original Message----- >>>> From: amd-gfx [mailto:amd-gfx-bounces at lists.freedesktop.org] On Behalf >>>> Of Christian König >>>> Sent: Thursday, October 26, 2017 12:06 PM >>>> To: amd-gfx at lists.freedesktop.org >>>> Subject: [PATCH 4/8] drm/amdgpu: don't wait interruptible while binding >>>> GART space >>>> >>>> From: Christian König <christian.koenig at amd.com> >>>> >>>> Display can't seem to handle this correctly. >>>> >>>> Signed-off-by: Christian König <christian.koenig at amd.com> >>> Acked-by: Alex Deucher <alexander.deucher at amd.com> >> >> BTW: Harry & Andrey: >> >> It is probably a good idea to actually wait interruptible here. >> >> How problematic would it be for you guys to allow that? >> >> The only negative effect I could find of hand is some error printing in the DC code. > > It shouldn't be an issue, as i trace this call i see it's gonna impact dm_plane_helper_prepare_fb through calling amdgpu_bo_pin, > so instead of treating any r != 0 as error we just should gracefully return for EINTR there w\o printing error. > I tend to agree. It should already work. Just sent a patch, though, to not print an error on EINTR. Harry > Thanks, > Andrey > >> >> Christian. >> >>> >>>> --- >>>>  drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +- >>>>  1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >>>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >>>> index e5cab4b..3045701 100644 >>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c >>>> @@ -913,7 +913,7 @@ int amdgpu_ttm_bind(struct ttm_buffer_object *bo, >>>> struct ttm_mem_reg *bo_mem) >>>>      placements.flags = (bo->mem.placement & ~TTM_PL_MASK_MEM) >>>> | >>>>          TTM_PL_FLAG_TT; >>>> >>>> -   r = ttm_bo_mem_space(bo, &placement, &tmp, true, false); >>>> +   r = ttm_bo_mem_space(bo, &placement, &tmp, false, false); >>>>      if (unlikely(r)) >>>>          return r; >>>> >>>> -- >>>> 2.7.4 >>>> >>>> _______________________________________________ >>>> amd-gfx mailing list >>>> amd-gfx at lists.freedesktop.org >>>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >>> _______________________________________________ >>> amd-gfx mailing list >>> amd-gfx at lists.freedesktop.org >>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx >> >> >
