On 2017-10-16 08:11 PM, Harry Wentland wrote:
> Having one struct on the stack was somewhat confusing. Also mention
> that the whole function should eventually go.
>
> Signed-off-by: Harry Wentland <harry.wentland at amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/core/dc.c | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 7a0593d4ca62..a71392ffc46d 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -918,6 +918,12 @@ bool dc_post_update_surfaces_to_stream(struct dc *dc)
> return true;
> }
>
> +/*
> + * TODO this whole function needs to go
> + *
> + * dc_surface_update is needlessly complex. See if we can just replace this
> + * with a dc_plane_state and follow the atomic model a bit more closely here.
> + */
> bool dc_commit_planes_to_stream(
> struct dc *dc,
> struct dc_plane_state **plane_states,
> @@ -925,6 +931,7 @@ bool dc_commit_planes_to_stream(
> struct dc_stream_state *dc_stream,
> struct dc_state *state)
> {
> + /* no need to dynamically allocate this. it's pretty small */
> struct dc_surface_update updates[MAX_SURFACES];
> struct dc_flip_addrs *flip_addr;
> struct dc_plane_info *plane_info;
Reviewed-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
