On Wed, Feb 19, 2025 at 05:49:01PM +0800, Huacai Chen wrote: > > Looks like that's not going to work. Without patch 7 I'm getting a > > warning (upgraded to a build error with a pending change to upgrade > > objtool warnings to errors): > > > > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot() falls through to next function crash_shutdown_secondary() > > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot+0x1c: (branch) > > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot+0x0: <=== (sym) > > arch/loongarch/kernel/machine_kexec.o: error: objtool: 1 warning(s) upgraded to errors > > > > And that would break bisection anyway, so that really needs to come > > before the others. > OK, then please take the whole series of V7, but please exchange the > order of Patch-6 and Patch-7 (I think the enablement should be the > last for bisection). > For V7: Acked-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> Ok, but to avoid the warning, patch 7 needs to come *before* the objtool patches, so it will be the following order: LoongArch: Convert unreachable() to BUG() objtool: Handle various symbol types of rodata objtool: Handle different entry size of rodata objtool: Handle PC relative relocation type objtool/LoongArch: Add support for switch table objtool/LoongArch: Add support for goto table LoongArch: Enable jump table for objtool -- Josh
