On Wed, Feb 19, 2025 at 1:46 AM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote: > > On Mon, Feb 17, 2025 at 11:13:43AM +0800, Huacai Chen wrote: > > On Thu, Feb 13, 2025 at 10:51 AM Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote: > > > > > > On Wed, Feb 12, 2025 at 03:22:45PM +0800, Huacai Chen wrote: > > > > > The new series now has 7 patches: > > > > > > > > > > Tiezhu Yang (7): > > > > > objtool: Handle various symbol types of rodata > > > > > objtool: Handle different entry size of rodata > > > > > objtool: Handle PC relative relocation type > > > > > objtool/LoongArch: Add support for switch table > > > > > objtool/LoongArch: Add support for goto table > > > > > LoongArch: Enable jump table for objtool > > > > > LoongArch: Convert unreachable() to BUG() > > > > > > > > > > I was planning on queueing all 7. > > > > > > > > > > In particular, patch 6 should stay with the objtool patches since > > > > > they're directly related. > > > > > > > > > > But I was also just going to grab 7 as well. > > > > > > > > > > Please let me know if you disagree. > > > > What about you merge the first 5 patches, and then I merge the last 2 > > > > to the loongarch tree? (I prefer to merge the whole series to the > > > > loongarch tree with your acked-by, but that may be inconvenient to > > > > you). > > > > > > I want the first 5 patches to go through the -tip tree because we'll > > > have other patches depending on them. > > > > > > I'll go ahead and take the first 5. > > > > > > If you take in patches 6 & 7 separately, that might introduce a lot of > > > warnings. But it's up to you. > > > > > > For patches 6 & 7: > > > > > > Acked-by: Josh Poimboeuf <jpoimboe@xxxxxxxxxx> > > OK, please take the first 5 patches, I will merge your objtool/core to > > the loongarch tree and then apply the last 2 to avoid build warnings. > > Looks like that's not going to work. Without patch 7 I'm getting a > warning (upgraded to a build error with a pending change to upgrade > objtool warnings to errors): > > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot() falls through to next function crash_shutdown_secondary() > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot+0x1c: (branch) > arch/loongarch/kernel/machine_kexec.o: error: objtool: kexec_reboot+0x0: <=== (sym) > arch/loongarch/kernel/machine_kexec.o: error: objtool: 1 warning(s) upgraded to errors > > And that would break bisection anyway, so that really needs to come > before the others. OK, then please take the whole series of V7, but please exchange the order of Patch-6 and Patch-7 (I think the enablement should be the last for bisection). For V7: Acked-by: Huacai Chen <chenhuacai@xxxxxxxxxxx> Huacai > > -- > Josh
