On Thu, May 11, 2017 at 10:50:17AM +0800, Zhou, David(ChunMing) wrote: > > > On 2017å¹´05æ??11æ?¥ 10:41, Deucher, Alexander wrote: > > > -----Original Message----- > > From: Deucher, Alexander > > Sent: Wednesday, May 10, 2017 10:38 PM > > To: Huang, Ray; amd-gfx at lists.freedesktop.org; Koenig, Christian > > Cc: Zhou, David(ChunMing); Wang, Ken; Huan, Alvin; Huang, Ray > > Subject: RE: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface > > > > > -----Original Message----- > > > From: Huang Rui [mailto:ray.huang at amd.com] > > > Sent: Wednesday, May 10, 2017 10:29 PM > > > To: amd-gfx at lists.freedesktop.org; Deucher, Alexander; Koenig, > Christian > > > Cc: Zhou, David(ChunMing); Wang, Ken; Huan, Alvin; Huang, Ray > > > Subject: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface > > > > > > Signed-off-by: Huang Rui <ray.huang at amd.com> > > > > Reviewed-by: Alex Deucher <alexander.deucher at amd.com> > > Not sure if it's important for this since it's debugfs, but we don't have > any sort of ring locks anymore (since everything should go through the > scheduler once it's started) so we could theoretically get collisions if > there are active apps using the GPU and you run these tests. > > Yes, agree. So patch#1 for ib test should use scheduler, but which could be a > big change and Christian doesn't like to use scheduler for ib test case, > consider this is only for test case, the problem isn't big:). Do you know any method to hold on the scheduler? > > btw: I think patch#2 isn't need if patch#1 is landed, since when you use this > sys interface, the amdgpu driver must be loaded successfully, ring test is > meaningless. > In normal case, ring tests&ib tests must be passed during boot&resume&reset phase. Is there anything that will break the ring test at runtime? Thanks, Rui
