On Wed, May 10, 2017 at 10:56 PM, Huang Rui <ray.huang at amd.com> wrote: > On Thu, May 11, 2017 at 10:41:42AM +0800, Deucher, Alexander wrote: >> > -----Original Message----- >> > From: Deucher, Alexander >> > Sent: Wednesday, May 10, 2017 10:38 PM >> > To: Huang, Ray; amd-gfx at lists.freedesktop.org; Koenig, Christian >> > Cc: Zhou, David(ChunMing); Wang, Ken; Huan, Alvin; Huang, Ray >> > Subject: RE: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface >> > >> > > -----Original Message----- >> > > From: Huang Rui [mailto:ray.huang at amd.com] >> > > Sent: Wednesday, May 10, 2017 10:29 PM >> > > To: amd-gfx at lists.freedesktop.org; Deucher, Alexander; Koenig, Christian >> > > Cc: Zhou, David(ChunMing); Wang, Ken; Huan, Alvin; Huang, Ray >> > > Subject: [PATCH 2/2] drm/amdgpu: export test ring debugfs interface >> > > >> > > Signed-off-by: Huang Rui <ray.huang at amd.com> >> > >> > Reviewed-by: Alex Deucher <alexander.deucher at amd.com> >> >> Not sure if it's important for this since it's debugfs, but we don't have any >> sort of ring locks anymore (since everything should go through the scheduler >> once it's started) so we could theoretically get collisions if there are active >> apps using the GPU and you run these tests. >> > > Right. Any idea to hold on scheduler when I try to run this test? Park the scheduler thread for each ring like we do for GPU reset? That said, I think the expectation is that you should only run these tests when the GPU is idle. Alex