[AMD Official Use Only - AMD Internal Distribution Only]
Thanks for the information. I draft this patch to resolve the HIP stream test that complained about the KFD process signals an invalidate fence on the latest drm-next branch. BTW, it looks like your patch still hasn't landed in the drm-next branch.
Regards,
Prike
> -----Original Message-----
> From: Zhu, Lingshan <Lingshan.Zhu@xxxxxxx>
> Sent: Thursday, January 2, 2025 3:13 PM
> To: Liang, Prike <Prike.Liang@xxxxxxx>; amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Deucher, Alexander <Alexander.Deucher@xxxxxxx>; Kuehling, Felix
> <Felix.Kuehling@xxxxxxx>; Koenig, Christian <Christian.Koenig@xxxxxxx>;
> Kasiviswanathan, Harish <Harish.Kasiviswanathan@xxxxxxx>
> Subject: Re: [PATCH] drm/amdkfd: test release process eviction fence before signal
>
> Hello Prike
>
> This issue has already been fixed, please see:
> https://www.spinics.net/lists/amd-gfx/msg117071.html
>
> Thanks
> Lingshan
> On 1/2/2025 2:30 PM, Prike Liang wrote:
> > It requires to validate the release process eviction fence before
> > signal the fence.
> >
> > Signed-off-by: Prike Liang <Prike.Liang@xxxxxxx>
> > ---
> > drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > index 0976b5b0e8e8..083f83c94531 100644
> > --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> > @@ -1160,7 +1160,8 @@ static void kfd_process_wq_release(struct work_struct
> *work)
> > */
> > synchronize_rcu();
> > ef = rcu_access_pointer(p->ef);
> > - dma_fence_signal(ef);
> > + if (ef)
> > + dma_fence_signal(ef);
> >
> > kfd_process_remove_sysfs(p);
> >
