Re: [PATCH v2 2/7] drm/amdgpu: Fix NULL ptr dereference issue for non userq fences

[Christian König <christian.koenig@xxxxxxx>]

Am 12.12.24 um 15:25 schrieb Arunpravin Paneer Selvam:
> Add the correct fences count variable [num_fences] in the fences
> array iteration to handle the userq / non-userq fences.
>
> v2:(Christian)
>    - All fences in the array either come from some reservation object
>      or drm_syncobj. If any of those are NULL then there is a bug
>      somewhere else.
>
> Signed-off-by: Arunpravin Paneer Selvam <Arunpravin.PaneerSelvam@xxxxxxx>

Reviewed-by: Christian König <christian.koenig@xxxxxxx>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> index 877cb17a14e9..3a88f754a395 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_userq_fence.c
> @@ -825,7 +825,7 @@ int amdgpu_userq_wait_ioctl(struct drm_device *dev, void *data,
>   			fences[num_fences++] = fence;
>   		}
>   
> -		for (i = 0, cnt = 0; i < wait_info->num_fences; i++) {
> +		for (i = 0, cnt = 0; i < num_fences; i++) {
>   			struct amdgpu_userq_fence_driver *fence_drv;
>   			struct amdgpu_userq_fence *userq_fence;
>   			u32 index;