On 12/4/2024 10:44 AM, Mario Limonciello wrote: > >>> +enum amdgpu_ucode_required { >>> + AMDGPU_UCODE_NOT_REQUIRED, >>> + AMDGPU_UCODE_REQUIRED, >> >> Couldn't this be handled in another API instead of having to flag every >> load? By default, every ucode is required and if optional may be skipped >> with amdgpu_ucode_request_optional() API? >> > > I guess this would be a smaller patch, but 6 eggs one hand, half dozen > in the other? > I thought only ISP and gpu_info (no longer there for newer SOCs) fall into the optional ones so far. The usage is rare, similar to the nowarn() API usage. Also, as far as I know, the cap microcode is a must whenever used. That is not optional. Thanks, Lijo > Alex - what's your take?