[AMD Official Use Only - General]
> -----Original Message-----
> From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> On Behalf Of Felix
> Kuehling
> Sent: Wednesday, April 10, 2024 4:05 PM
> To: amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> Cc: Chen, Xiaogang <Xiaogang.Chen@xxxxxxx>
> Subject: [PATCH] drm/amdkfd: Fix memory leak in create_process failure
>
> Caution: This message originated from an External Source. Use proper caution
> when opening attachments, clicking links, or responding.
>
>
> Fix memory leak due to a leaked mmget reference on an error handling code
> path that is triggered when attempting to create KFD processes while a GPU
> reset is in progress.
>
> Fixes: 0ab2d7532b05 ("drm/amdkfd: prepare per-process debug enable and
> disable")
> CC: Xiaogang Chen <xiaogang.chen@xxxxxxx>
> Signed-off-by: Felix Kuehling <felix.kuehling@xxxxxxx>
Reviewed-by: Mukul Joshi <mukul.joshi@xxxxxxx>
> ---
> drivers/gpu/drm/amd/amdkfd/kfd_process.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> index 717a60d7a4ea..b79986412cd8 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c
> @@ -819,9 +819,9 @@ struct kfd_process *kfd_create_process(struct
> task_struct *thread)
> mutex_lock(&kfd_processes_mutex);
>
> if (kfd_is_locked()) {
> - mutex_unlock(&kfd_processes_mutex);
> pr_debug("KFD is locked! Cannot create process");
> - return ERR_PTR(-EINVAL);
> + process = ERR_PTR(-EINVAL);
> + goto out;
> }
>
> /* A prior open of /dev/kfd could have already created the process. */
> --
> 2.34.1
