Hi Michel, MODULE_PARM_DESC is "used to document arguments that the module can take. It takes two parameters: a variable name and a free form string describing that variable" I think we should avoid changing document when config change. How about changing it to something like the following example? MODULE_PARM_DESC(pos_buf_per_se, "the size of Position Buffer per Shader Engine (default depending on gfx)"); Thanks, Alex Bin On 2017-06-30 04:36 AM, Michel Dänzer wrote: > From: Michel Dänzer <michel.daenzer at amd.com> > > It was required to explicitly set these parameters to 1, even if the > radeon driver isn't built at all, which is not intuitive. > > Reported-by: Shawn Starr <shawn.starr at rogers.com> > Signed-off-by: Michel Dänzer <michel.daenzer at amd.com> > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > index 27599db7d630..58770fc40520 100644 > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c > @@ -234,14 +234,28 @@ MODULE_PARM_DESC(param_buf_per_se, "the size of Off-Chip Pramater Cache per Shad > module_param_named(param_buf_per_se, amdgpu_param_buf_per_se, int, 0444); > > #ifdef CONFIG_DRM_AMDGPU_SI > + > +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) > int amdgpu_si_support = 0; > MODULE_PARM_DESC(si_support, "SI support (1 = enabled, 0 = disabled (default))"); > +#else > +int amdgpu_si_support = 1; > +MODULE_PARM_DESC(si_support, "SI support (1 = enabled (default), 0 = disabled)"); > +#endif > + > module_param_named(si_support, amdgpu_si_support, int, 0444); > #endif > > #ifdef CONFIG_DRM_AMDGPU_CIK > + > +#if defined(CONFIG_DRM_RADEON) || defined(CONFIG_DRM_RADEON_MODULE) > int amdgpu_cik_support = 0; > MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled, 0 = disabled (default))"); > +#else > +int amdgpu_cik_support = 1; > +MODULE_PARM_DESC(cik_support, "CIK support (1 = enabled (default), 0 = disabled)"); > +#endif > + > module_param_named(cik_support, amdgpu_cik_support, int, 0444); > #endif >
