On 30/06/17 11:41 PM, axie wrote: > Hi Michel, > > MODULE_PARM_DESC is "used to document arguments that the module can > take. It takes two parameters: a variable name and a free form string > describing that variable" > > I think we should avoid changing document when config change. > > How about changing it to something like the following example? > > MODULE_PARM_DESC(pos_buf_per_se, "the size of Position Buffer per Shader > Engine (default depending on gfx)"); What would be the benefit of that? With this patch, the parameter description as printed by modinfo always explicitly and accurately documents the default value. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer