On Thu, Jun 22, 2017 at 5:33 PM, Xie, AlexBin <AlexBin.Xie at amd.com> wrote: > Hi Christian, > > > In fact, the change from spinlock to atomic is quite painful. When I > started, I thought it was easy but later I found there might be race > condition here and there. Now I think the change looks more robust. In > kernel source, there are several other drivers used the same trick. > > > On the other hand, I think the logic itself might be optimized considering > the locking. But I had spent quite some effort to maintain original logic. It seems quite complicated and I don't know if there is any performance benefit. Spinlocks are nice because they allow preemption. It would be more interesting to merge the CS and BO_LIST ioctls into one. Marek
