Hi Christian,
In fact, the change from spinlock to atomic is quite painful. When I started, I thought it was easy but later I found there might be race condition here and there. Now I think the change looks more robust. In kernel source, there are several other drivers used the same trick.
On the other hand, I think the logic itself might be optimized considering the locking. But I had spent quite some effort to maintain original logic.
Thanks,
Alex Bin
From: Christian König <deathsimple@xxxxxxxxxxx>
Sent: Thursday, June 22, 2017 3:35 AM
To: Xie, AlexBin; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 1/3] drm/amdgpu: fix a typo
Am 22.06.2017 um 04:42 schrieb Alex Xie:
> Signed-off-by: Alex Xie <AlexBin.Xie at amd.com>
With the commit message fixed as Michel suggested patches #1 and #2 are
Reviewed-by: Christian König <christian.koenig at amd.com> as well.
On patch #3 Marek needs to take a look, cause I don't know the logic
behind that.
Regards,
Christian.
> ---
> drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> index 7635f38..94c27fc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c
> @@ -494,7 +494,7 @@ static int amdgpu_cs_parser_bos(struct amdgpu_cs_parser *p,
> &e->user_invalidated) && e->user_pages) {
>
> /* We acquired a page array, but somebody
> - * invalidated it. Free it an try again
> + * invalidated it. Free it and try again
> */
> release_pages(e->user_pages,
> e->robj->tbo.ttm->num_pages,
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170622/5c39be7e/attachment-0001.html>
