>>s/diable/disable/
>>Also, why not make "Failed" lower-case at the same time?
Of course. thanks.
Best Regards
Rex
________________________________
From: amd-gfx <amd-gfx-bounces@xxxxxxxxxxxxxxxxxxxxx> on behalf of William Lewis <minutemaidpark at hotmail.com>
Sent: Thursday, June 8, 2017 8:47:58 PM
To: amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH] drm/amd/powerplay: fix copy error in powerplay.
On 06/08/2017 02:50 AM, Rex Zhu wrote:
> should disable led dpm feature when stop dpm.
>
> Change-Id: I9d78459ff2467d2eba0b26d9696138f7eba484a0
> Signed-off-by: Rex Zhu <Rex.Zhu at amd.com>
> ---
> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> index 9338aca..b6df00c 100644
> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c
> @@ -2702,9 +2702,9 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
>
> if(data->smu_features[GNLD_LED_DISPLAY].supported == true){
> PP_ASSERT_WITH_CODE(!vega10_enable_smc_features(hwmgr->smumgr,
> - true, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
> - "Attempt to Enable LED DPM feature Failed!", return -EINVAL);
> - data->smu_features[GNLD_LED_DISPLAY].enabled = true;
> + false, data->smu_features[GNLD_LED_DISPLAY].smu_feature_bitmap),
> + "Attempt to diable LED DPM feature Failed!", return -EINVAL);
s/diable/disable/
Also, why not make "Failed" lower-case at the same time?
> + data->smu_features[GNLD_LED_DISPLAY].enabled = false;
> }
>
> for (i = 0; i < GNLD_DPM_MAX; i++) {
_______________________________________________
amd-gfx mailing list
amd-gfx at lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20170609/e8a0ca1b/attachment.html>
