[PATCH 5/6] drm/amdgpu/powerplay: add an implementation for get_vce_clock_table

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Oct 12, 2016 at 5:56 AM, Christian König
<deathsimple at vodafone.de> wrote:
> Hi Rex,
>
> So amd_vce_state is our hardware representation and
> drm_amdgpu_info_vce_clock_table is the IOCTL interface structure? Is there a
> reason for not using drm_amdgpu_info_vce_clock_table directly in the hw
> manager, except that we don't want to include the IOCTL interface here?
>
> Cause that would at least be a bit awkward, this is an extra abstraction
> layer we usually try to avoid upstream.
>
> I'm fine with this approach for this use case, but when we get more and more
> power management exposed to userspace this could raise objections cause this
> essentially means we need to duplicate all internal power management
> structures for the public interface again.

It's only needed for a subset of asics (some CI and VI parts).
Everything else gets handled in the firmware similar to UVD DPM.

Alex


[Index of Archives]     [Linux USB Devel]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux