On Mon, Aug 22, 2016 at 3:18 AM, Dave Airlie <airlied at gmail.com> wrote: > On 19 August 2016 at 19:01, Marek Olšák <maraeo at gmail.com> wrote: >> Hi, >> >> This amdgpu patch fixes DCE support. Now only the cursor is broken: >> >> [ 37.936022] [drm:dce_v6_0_crtc_cursor_set2 [amdgpu]] *ERROR* bad cursor width or height 128 x 128 >> >> Everything else seems to work. I've not tested UVD and VCE. >> >> Now I'm gonna send out all userspace patches that I intend to merge before the kernel support lands. I think that shouldn't be a problem. > > Please don't land anything in userspace until kernel side is in > drm-next. At least if it's kernel API related. > > Been burned too many times with people shipping libdrm before > something got set in stone in the kernel. There is just a new definition in amdgpu_drm.h: AMDGPU_FAMILY_SI However, userspace doesn't need it, which means there is practically no kernel API change from the userspace point of view. I can delay pushing the AMDGPU_FAMILY_SI definition, but I don't think anything else needs to be delayed. Marek