On Wed, Oct 30, 2019 at 4:55 AM Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> wrote: > > > > On 29/10/2019 20:47, Rob Herring wrote: > > On Mon, Oct 28, 2019 at 7:45 AM Srinivas Kandagatla > > <srinivas.kandagatla@xxxxxxxxxx> wrote: > >> > >> > >> > >> On 28/10/2019 12:40, Srinivas Kandagatla wrote: > >>> Its Phandle. > >>> > >>> something like this is okay? > >>> > >>> slim-ifc-dev: > >>> $ref: '/schemas/types.yaml#/definitions/phandle-array' > >> > >> Sorry this should not be an array, so something like this: > >> > >> slim-ifc-dev: > >> description: SLIMBus Interface device phandle > > > > You're just spelling out the abbreviated name. I can do that much. > > What is 'SLIMBus Interface device'? > > Each SLIMBus Component contains one Interface Device. Which is > responsible for Monitoring and reporting the status of component, Data > line to Data pin connection setup for SLIMBus streaming. Interface > device is enumerated just like any other slim device. So a standard set of registers every slimbus device has? In hindsight, I would have made reg have 2 entries with both addresses. I guess that ship has sailed. It seems strange you would need both "devices" described as separate nodes in DT. > > We already have exactly same bindings for WCD9335 in upstream at: > > https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/devicetree/bindings/sound/qcom,wcd9335.txt?h=v5.4-rc5#n42 > > > > > Is it a standard SLIMBus property? If so, document it in the right > > place. If not, then needs a vendor prefix. > > "SLIMBus Interface Device" itself is documented in SLIMBus Specification. > > If I remember it correctly You suggested me to move to "slim-ifc-dev" > as this is part of SLIMBus Specification. Probably so. If it is common, then document it in bindings/slimbus/bus.txt. Then here, 'slim-ifc-dev: true' is sufficient. You can just assume we convert bus.txt to schema (or feel free to do that :) ). Rob _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel