On Mon, Oct 21, 2019 at 9:08 AM Nuno Sá <nuno.sa@xxxxxxxxxx> wrote:
>
> This changes are in accordance with the review done to this bindings.
> This is a follow-up patch to 969d49b2cdc8.
>
> Signed-off-by: Nuno Sá <nuno.sa@xxxxxxxxxx>
> ---
> .../bindings/sound/adi,adau7118.yaml | 25 ++++++++-----------
> 1 file changed, 10 insertions(+), 15 deletions(-)
Still some issues here...
>
> diff --git a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> index cfcef602b3d9..c3f10afbdd6f 100644
> --- a/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> +++ b/Documentation/devicetree/bindings/sound/adi,adau7118.yaml
> @@ -26,13 +26,11 @@ properties:
> "#sound-dai-cells":
> const: 0
>
> - IOVDD-supply:
> + iovdd-supply:
> description: Digital Input/Output Power Supply.
> - $ref: "/schemas/types.yaml#/definitions/phandle"
>
> - DVDD-supply:
> + dvdd-supply:
> description: Internal Core Digital Power Supply.
> - $ref: "/schemas/types.yaml#/definitions/phandle"
>
> adi,decimation-ratio:
> description: |
> @@ -58,23 +56,21 @@ properties:
> required:
> - "#sound-dai-cells"
> - compatible
> - - IOVDD-supply
> - - DVDD-supply
> + - iovdd-supply
> + - dvdd-supply
>
> examples:
> - |
> - i2c0 {
> + i2c {
> /* example with i2c support */
> #address-cells = <1>;
> #size-cells = <0>;
> - status = "okay";
> - adau7118_codec: adau7118-codec@14 {
> + adau7118_codec: audio-codec@14 {
Documentation/devicetree/bindings/sound/adi,adau7118.example.dts:21.44-29.15:
Warning (i2c_bus_reg): /example-0/i2c/audio-codec@14: I2C bus unit
address format error, expected "e"
Unit-address should be in hex.
> compatible = "adi,adau7118";
> reg = <14>;
> #sound-dai-cells = <0>;
> - status = "okay";
> - IOVDD-supply = <&supply>;
> - DVDD-supply = <&supply>;
> + iovdd-supply = <&supply>;
> + dvdd-supply = <&supply>;
> adi,pdm-clk-map = <1 1 0 0>;
> adi,decimation-ratio = <16>;
> };
> @@ -84,7 +80,6 @@ examples:
> adau7118_codec_hw: adau7118-codec-hw {
> compatible = "adi,adau7118";
> #sound-dai-cells = <0>;
> - status = "okay";
> - IOVDD-supply = <&supply>;
> - DVDD-supply = <&supply>;
> + iovdd-supply = <&supply>;
> + dvdd-supply = <&supply>;
> };
> --
> 2.23.0
>
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
