On Tue, 2019-07-30 at 17:19 -0400, Josh Boyer wrote: > > I don't understand what you're suggesting nor how it would work > > with the > > way the kernel deals with directories. I tried to explain that we > > need > > an intel/sof-production and intel/sof directories, each with > > generic > > names that are symlinked to another location. This helps if you > > want to > > build quirks that select one or the other capabilities by just > > changing > > the firmware directory prefix. Pointers below. > > > > https://github.com/thesofproject/linux/blob/9d7da69a1e85db2cdbbaae78dd7eda4eeaa1eb1c/sound/soc/sof/sof-pci-dev.c#L24 > > > > https://github.com/thesofproject/linux/blob/9d7da69a1e85db2cdbbaae78dd7eda4eeaa1eb1c/sound/soc/sof/loader.c#L269 > > > > https://github.com/thesofproject/linux/blob/9d7da69a1e85db2cdbbaae78dd7eda4eeaa1eb1c/sound/soc/sof/sof-pci-dev.c#L149 So the commit did support this, but it would put all "production" signed binaries at the intel/sof/ level via soft links (to be automatically loaded by the driver as the default). A subsequent commit would have added the community signed images. I planned to link community signed binaries at the intel/sof/community level since most users would use the production signed images by default (and would not need to use a module param to select). My assumption was that machines using community signed by default would have this in their default_fw_path ? > > > > I guess we need to talk off-line since we are evidently not on the > > same > > page or something is missing for people to use this pull request. > > I suggest you guys do that. At the moment, I'm not pulling anything > related to this until it has a signoff from both you and Liam in the > commit logs at a minimum. Yep, no problem - Pierre and I will refine and resend shortly. I also need to remove links for aliases. Thanks Liam _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
