Re: [Sound-open-firmware] [GIT PULL] SOF v1.3 firmware binaries

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[fixed alsa-devel email]

On 7/30/19 10:33 AM, Liam Girdwood wrote:
The following changes since commit dff98c6c57383fe343407bcb7b6e775e0b87274f:

   Merge branch 'master' of git://github.com/skeggsb/linux-firmware (2019-07-26 07:32:37 -0400)

are available in the Git repository at:

   https://github.com/thesofproject/linux-firmware.git sof-v1.3

for you to fetch changes up to cde3a116cea96976125b9215b303edfda85c9b54:

   sof: Add Intel SOF V1.3 release firmware binaries. (2019-07-30 16:06:41 +0100)

----------------------------------------------------------------
Liam Girdwood (1):
       sof: Add Intel SOF V1.3 release firmware binaries.

  LICENCE.sof                                  | 1090 ++++++++++++++++++++++++++

Humm, that LICENSE file needs to be double-checked. Is there any reason why the text of this LICENSE.sof is different the usual text, e.g. from the LICENSE.adsp_sst?

You are missing both the first part:

***** INTEL BINARY FIRMWARE RELEASE LICENCE ********************************

Copyright (c) 2014-15 Intel Corporation.
All rights reserved.

Redistribution.

Redistribution and use in binary form, without modification, are permitted
provided that the following conditions are met:
*    Redistributions must reproduce the above copyright notice and the
following disclaimer in the documentation and/or other materials provided
     with the distribution.
* Neither the name of Intel Corporation nor the names of its suppliers may be used to endorse or promote products derived from this software without
     specific prior written permission.
* No reverse engineering, decompilation, or disassembly of this software is
     permitted.

and the DISCLAIMER part, both of which seem pretty important to me. IANAL, but seeing only a patent clause looks odd. There should be a mention of redistribution and a clear disclaimer (not sure about the reverse engineering parts since the code is available it makes no sense).

  WHENCE                                       |   33 +
  intel/sof/apl/intel/sof-apl-v1.3.ri          |  Bin 0 -> 270336 bytes
  intel/sof/bdw/sof-bdw-v1.3.ri                |  Bin 0 -> 100144 bytes
  intel/sof/byt/sof-byt-v1.3.ri                |  Bin 0 -> 89668 bytes
  intel/sof/cht/sof-cht-v1.3.ri                |  Bin 0 -> 90484 bytes
  intel/sof/cnl/intel/sof-cnl-v1.3-6cc8da10.ri |  Bin 0 -> 274432 bytes
  intel/sof/icl/intel/sof-icl-v1.3.ri          |  Bin 0 -> 278528 bytes

There are two types of platforms, the ones which require the Intel firmware to be signed with a private production key and the ones that are signed with the SOF community key.

if we have a single directory, then how do we deal with the two cases? It's not even clear to me which of the two cases are handled here.

  intel/sof/sof-apl.ri                         |    1 +
  intel/sof/sof-bdw.ri                         |    1 +
  intel/sof/sof-byt.ri                         |    1 +
  intel/sof/sof-cht.ri                         |    1 +
  intel/sof/sof-cml.ri                         |    1 +
  intel/sof/sof-cnl.ri                         |    1 +
  intel/sof/sof-glk.ri                         |    1 +
  intel/sof/sof-icl.ri                         |    1 +
  intel/sof/sof-whl.ri                         |    1 +

unless I am missing something, we don't have any tables in the Linux kernel for the WHL and CML configurations, and IIRC we only generate sof-cnl.ri. Is there actually a user for sof-whl.ri and sof-cml.ri?


  17 files changed, 1132 insertions(+)
  create mode 100644 LICENCE.sof
  create mode 100644 intel/sof/apl/intel/sof-apl-v1.3.ri
  create mode 100644 intel/sof/bdw/sof-bdw-v1.3.ri
  create mode 100644 intel/sof/byt/sof-byt-v1.3.ri
  create mode 100644 intel/sof/cht/sof-cht-v1.3.ri
  create mode 100644 intel/sof/cnl/intel/sof-cnl-v1.3-6cc8da10.ri
  create mode 100644 intel/sof/icl/intel/sof-icl-v1.3.ri
  create mode 120000 intel/sof/sof-apl.ri
  create mode 120000 intel/sof/sof-bdw.ri
  create mode 120000 intel/sof/sof-byt.ri
  create mode 120000 intel/sof/sof-cht.ri
  create mode 120000 intel/sof/sof-cml.ri
  create mode 120000 intel/sof/sof-cnl.ri
  create mode 120000 intel/sof/sof-glk.ri
  create mode 120000 intel/sof/sof-icl.ri
  create mode 120000 intel/sof/sof-whl.ri

_______________________________________________
Sound-open-firmware mailing list
Sound-open-firmware@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/sound-open-firmware


_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux