On Fri, 24 May 2019 15:16:05 +0200, Pierre-Louis Bossart wrote: > > > > On 5/24/19 2:54 AM, Takashi Iwai wrote: > > On Fri, 24 May 2019 01:39:48 +0200, > > Pierre-Louis Bossart wrote: > >> > >> Move parts of the code outside of the Skylake driver to help detect > >> the presence of DMICs (which are not supported by the HDaudio legacy > >> driver). > >> > >> No functionality change, only indentation and checkpatch fixes, and making sure that the code compiles without ACPI > >> > >> Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx> > > > > This is no ASoC-specific code, which will be called from the legacy > > HDA driver, too. So better to drop SOC_ prefix. > > ok. > I also thought about the location of the code, I am not sure this > works if SND_SOC is not selected. > > If SND_SOC is not selected, there is also no conflict with another > driver so we may want to bypass this code. Or use it, flag that the > config will prevent capture from working but continue the probe so > that the playback works at least. Actually since the code is shared among ASoC and other parts, it might make sense to move it into sound/hda common directory, too. Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx https://mailman.alsa-project.org/mailman/listinfo/alsa-devel
