Re: [RFC PATCH 3/6] ASoC: Intel: common: move parts of NHLT code to new module

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 5/24/19 2:54 AM, Takashi Iwai wrote:
On Fri, 24 May 2019 01:39:48 +0200,
Pierre-Louis Bossart wrote:

Move parts of the code outside of the Skylake driver to help detect
the presence of DMICs (which are not supported by the HDaudio legacy
driver).

No functionality change, only indentation and checkpatch fixes, and making sure that the code compiles without ACPI

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>

This is no ASoC-specific code, which will be called from the legacy
HDA driver, too.  So better to drop SOC_ prefix.

ok.
I also thought about the location of the code, I am not sure this works if SND_SOC is not selected.

If SND_SOC is not selected, there is also no conflict with another driver so we may want to bypass this code. Or use it, flag that the config will prevent capture from working but continue the probe so that the playback works at least.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux