Re: [PATCH] ALSA: seq: Correct unlock sequence at snd_seq_client_ioctl_unlock()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, 15 Apr 2019, Takashi Iwai wrote:

> The doubly unlock sequence at snd_seq_client_ioctl_unlock() is tricky.
> I took a direct unref call since I thought it would avoid
> misunderstanding, but rather this seems more confusing.  Let's use
> snd_seq_client_unlock() consistently even if they look strange to be
> called twice, and add more comments for avoiding reader's confusion.
> 
> Fixes: 6b580f523172 ("ALSA: seq: Protect racy pool manipulation from OSS sequencer")
> Signed-off-by: Takashi Iwai <tiwai@xxxxxxx>
> ---
>  sound/core/seq/seq_clientmgr.c | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)

thanks, looks good now (this and rest of the clean-up series):
  Reviewed-by: Kai Vehmanen <kai.vehmanen@xxxxxxxxxxxxxxx>

Br, Kai
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux