On Tue, 19 Feb 2019 16:50:00 +0100, Johannes Berg wrote: > > On Tue, 2019-02-19 at 16:31 +0100, Takashi Iwai wrote: > > We forgot to unreference a node obtained via of_find_node_by_name() > > after its usage. > > How did you find this now?! Though I guess something like smatch could > find it, or even coccinelle? I'm old-fashioned, just did manual reviews casually after the discussion about the recent regression regarding OF node refcount in an ASoC driver :) A coccinelle or such would be smarter, yeah :) > > Only compile-tested. Please review carefully. Thanks! > > Yes, looks right > > Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx> > > I still have, but no longer run, the machine that uses this driver ... > anyone need a Powermac G5 quad? ;-) Let's seek for museums :) thanks, Takashi _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
