Re: [PATCH 2/3] ALSA: aoa: Fix of-node refcount unbalance

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2019-02-19 at 16:31 +0100, Takashi Iwai wrote:
> We forgot to unreference a node obtained via of_find_node_by_name()
> after its usage.

How did you find this now?! Though I guess something like smatch could
find it, or even coccinelle?

> Only compile-tested.  Please review carefully.  Thanks!

Yes, looks right

Reviewed-by: Johannes Berg <johannes@xxxxxxxxxxxxxxxx>

I still have, but no longer run, the machine that uses this driver ...
anyone need a Powermac G5 quad? ;-)

johannes

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux