Re: [PATCH] UCM: bytcr/PlatformEnableSeq.conf update some comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 03 Feb 2019 12:37:41 +0100,
Hans de Goede wrote:
> 
> Commit f91cc3c7d6b7 ("Update chtrt5645 ucm variants to use
> bytcr/PlatformEnableSeq.conf component") updated the
> following 2 comments:
> 
>  # codec0_out settings (used if SSP2 is connected to aif1)
>  # modem_out settings (used if SSP0 is connected to aif2)
> 
> Specifically it added the " to aif1" resp. " to aif2" part of the comments.
> 
> This is not correct, AIF1 / AIF2 are something which is present on
> Realtek codecs only, and either one can be used indepedent of
> SSP0 or SSP2 being used (the comments in the chtrt5645 UCM profile
> before this change were wrong / outdated).
> 
> Besides there not being any relationship between SSP0 or SSP2 being
> used, bytcr/PlatformEnableSeq.conf is also used with other codecs,
> e.g. the ESS8316 codec where this is not applicable at all.
> 
> Therefor this commit removes the " to aif?" part of the comments again
> to avoid confusing people reading this in the future.
> 
> Cc: Russell Parker <russell.parker7@xxxxxxxxx>
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>

Applied now.  Thanks.


Takashi
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux