>-----Original Message----- >From: Mark Brown <broonie@xxxxxxxxxx> >Sent: Thursday, November 29, 2018 3:26 AM >To: Grant Grundler <grundler@xxxxxxxxxxxx> >Cc: Ryan Lee <RyanS.Lee@xxxxxxxxxxxxxxxxxxx>; Liam Girdwood ><lgirdwood@xxxxxxxxx>; perex@xxxxxxxx; tiwai@xxxxxxxx; Kuninori >Morimoto <kuninori.morimoto.gx@xxxxxxxxxxx>; Benson Leung ><bleung@xxxxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; LKML <linux- >kernel@xxxxxxxxxxxxxxx>; ryan.lee.maxim@xxxxxxxxx >Subject: Re: [PATCH V2] ASoC: max98373: Added max98373_reset for stable >amp reset > >On Wed, Nov 28, 2018 at 05:55:48PM -0800, Grant Grundler wrote: >> On Wed, Nov 28, 2018 at 9:07 AM Ryan Lee ><RyanS.Lee@xxxxxxxxxxxxxxxxxxx> wrote: > >> > >Not seeing a changelog here like I asked for :( > >> > Actually I added changelog as below. Do you mean this is not sufficient? > >> The text is probably sufficient but not in a format that Mark can >> directly apply. >> Please take a quick look at Documentation/process/submitting-patches.rst. > >> Mark wants the "commit message" to be before the '---' line. So move >> the "Changes:" text up to become the commit message and drop the >> "Changes" line. That should explain why this commit is needed and >> include the S-o-B line. > >Right. If you compare what's in git and what you're sending with other >commits and mails and make sure everything looks similar you're probably on >the right track. I'm sorry for the mistake. Let me fix it. _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
