Re: [PATCH] ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.20-rc3 next-20181123]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-Replace-snd_malloc_pages-and-snd_free_pages-with-standard-helpers/20181124-151811
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: i386-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-1) 7.3.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   sound/isa/wss/wss_lib.c: In function 'snd_wss_playback_open':
>> sound/isa/wss/wss_lib.c:1534:3: error: implicit declaration of function 'snd_free_pages'; did you mean '__free_pages'? [-Werror=implicit-function-declaration]
      snd_free_pages(runtime->dma_area, runtime->dma_bytes);
      ^~~~~~~~~~~~~~
      __free_pages
   cc1: some warnings being treated as errors

vim +1534 sound/isa/wss/wss_lib.c

^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1497  
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1498   */
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1499  
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1500  static int snd_wss_playback_open(struct snd_pcm_substream *substream)
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1501  {
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1502  	struct snd_wss *chip = snd_pcm_substream_chip(substream);
ba2375a4 sound/isa/cs423x/cs4231_lib.c Takashi Iwai   2005-11-17  1503  	struct snd_pcm_runtime *runtime = substream->runtime;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1504  	int err;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1505  
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1506  	runtime->hw = snd_wss_playback;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1507  
ead893c0 sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1508  	/* hardware limitation of older chipsets */
ead893c0 sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1509  	if (chip->hardware & WSS_HW_AD1848_MASK)
ead893c0 sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1510  		runtime->hw.formats &= ~(SNDRV_PCM_FMTBIT_IMA_ADPCM |
ead893c0 sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1511  					 SNDRV_PCM_FMTBIT_S16_BE);
ead893c0 sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1512  
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1513  	/* hardware bug in InterWave chipset */
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1514  	if (chip->hardware == WSS_HW_INTERWAVE && chip->dma1 > 3)
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1515  		runtime->hw.formats &= ~SNDRV_PCM_FMTBIT_MU_LAW;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1516  
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1517  	/* hardware limitation of cheap chips */
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1518  	if (chip->hardware == WSS_HW_CS4235 ||
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1519  	    chip->hardware == WSS_HW_CS4239)
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1520  		runtime->hw.formats = SNDRV_PCM_FMTBIT_U8 | SNDRV_PCM_FMTBIT_S16_LE;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1521  
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1522  	snd_pcm_limit_isa_dma_size(chip->dma1, &runtime->hw.buffer_bytes_max);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1523  	snd_pcm_limit_isa_dma_size(chip->dma1, &runtime->hw.period_bytes_max);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1524  
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1525  	if (chip->claim_dma) {
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1526  		if ((err = chip->claim_dma(chip, chip->dma_private_data, chip->dma1)) < 0)
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1527  			return err;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1528  	}
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1529  
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1530  	err = snd_wss_open(chip, WSS_MODE_PLAY);
7779f75f sound/isa/wss/wss_lib.c       Krzysztof Helt 2008-07-31  1531  	if (err < 0) {
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1532  		if (chip->release_dma)
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1533  			chip->release_dma(chip, chip->dma_private_data, chip->dma1);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16 @1534  		snd_free_pages(runtime->dma_area, runtime->dma_bytes);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1535  		return err;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1536  	}
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1537  	chip->playback_substream = substream;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1538  	snd_pcm_set_sync(substream);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1539  	chip->rate_constraint(runtime);
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1540  	return 0;
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1541  }
^1da177e sound/isa/cs423x/cs4231_lib.c Linus Torvalds 2005-04-16  1542  

:::::: The code at line 1534 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux