Re: [PATCH] ALSA: Replace snd_malloc_pages() and snd_free_pages() with standard helpers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Takashi,

I love your patch! Yet something to improve:

[auto build test ERROR on sound/for-next]
[also build test ERROR on v4.20-rc3 next-20181123]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Takashi-Iwai/ALSA-Replace-snd_malloc_pages-and-snd_free_pages-with-standard-helpers/20181124-151811
base:   https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git for-next
config: sparc64-defconfig (attached as .config)
compiler: sparc64-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.2.0 make.cross ARCH=sparc64 

All errors (new ones prefixed by >>):

   sound/sparc/cs4231.c: In function 'snd_cs4231_playback_open':
>> sound/sparc/cs4231.c:1150:3: error: implicit declaration of function 'snd_free_pages'; did you mean '__free_pages'? [-Werror=implicit-function-declaration]
      snd_free_pages(runtime->dma_area, runtime->dma_bytes);
      ^~~~~~~~~~~~~~
      __free_pages
   cc1: some warnings being treated as errors

vim +1150 sound/sparc/cs4231.c

^1da177e Linus Torvalds 2005-04-16  1139  
be9b7e8c Takashi Iwai   2006-01-03  1140  static int snd_cs4231_playback_open(struct snd_pcm_substream *substream)
^1da177e Linus Torvalds 2005-04-16  1141  {
be9b7e8c Takashi Iwai   2006-01-03  1142  	struct snd_cs4231 *chip = snd_pcm_substream_chip(substream);
be9b7e8c Takashi Iwai   2006-01-03  1143  	struct snd_pcm_runtime *runtime = substream->runtime;
^1da177e Linus Torvalds 2005-04-16  1144  	int err;
^1da177e Linus Torvalds 2005-04-16  1145  
^1da177e Linus Torvalds 2005-04-16  1146  	runtime->hw = snd_cs4231_playback;
^1da177e Linus Torvalds 2005-04-16  1147  
9e9abb4f Krzysztof Helt 2007-09-10  1148  	err = snd_cs4231_open(chip, CS4231_MODE_PLAY);
9e9abb4f Krzysztof Helt 2007-09-10  1149  	if (err < 0) {
^1da177e Linus Torvalds 2005-04-16 @1150  		snd_free_pages(runtime->dma_area, runtime->dma_bytes);
^1da177e Linus Torvalds 2005-04-16  1151  		return err;
^1da177e Linus Torvalds 2005-04-16  1152  	}
^1da177e Linus Torvalds 2005-04-16  1153  	chip->playback_substream = substream;
^1da177e Linus Torvalds 2005-04-16  1154  	chip->p_periods_sent = 0;
^1da177e Linus Torvalds 2005-04-16  1155  	snd_pcm_set_sync(substream);
^1da177e Linus Torvalds 2005-04-16  1156  	snd_cs4231_xrate(runtime);
^1da177e Linus Torvalds 2005-04-16  1157  
^1da177e Linus Torvalds 2005-04-16  1158  	return 0;
^1da177e Linus Torvalds 2005-04-16  1159  }
^1da177e Linus Torvalds 2005-04-16  1160  

:::::: The code at line 1150 was first introduced by commit
:::::: 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2 Linux-2.6.12-rc2

:::::: TO: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>
:::::: CC: Linus Torvalds <torvalds@xxxxxxxxxxxxxxx>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip

_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Pulse Audio]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux