Hi,
On 25-06-18 12:45, Mark Brown wrote:
On Sun, Jun 24, 2018 at 03:02:46PM +0200, Hans de Goede wrote:
The rt5651 does not have a built-in speaker amplifier, so it is often
used together with an external amplifier. On some boards the external
amplifier's enable pin is driven through a GPIO, add support for this.
This obviously shouldn't be part of the CODEC driver since it's not part
of the device, you should make a driver for GPIO controlled amplifiers
and add it to the card. There's actually a guy I've been talking to a
bit on IRC recently who's just written one actually and will hopefully
be posting it soon.
Hmm, that seems like a complicated solution to use for non DT platforms
I already need to deal with this in the sound/soc/intel/boards/bytcr_rt5651.c
machine driver (call devm_acpi_dev_add_driver_gpios), so I'm tempted to
model this a supply for the speaker (which it in essence is) inside the
machine driver and make that supply directly control the GPIO, would
that be acceptable?
Regards,
Hans
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
