On Mon, 2018-06-25 at 14:07 +0200, Nicolò Veronese wrote: > If you can do it, it's better. > I'm still learning, take care that the "simple-amplifier" can support supplys. supplies support makes sense. If I may suggest the following: * 1) Just perform a simple rename/sed first (Don't forget the DT documentation) * 2) Add your compatible to the list * 3) Add optional supply support if you need it Cheers Jerome > > Regards, > Nicolò > > Il giorno lun 25 giu 2018 alle ore 13:51 Jerome Brunet <jbrunet@xxxxxxxxxxxx> ha scritto: > > On Mon, 2018-06-25 at 12:44 +0100, Mark Brown wrote: > > > On Mon, Jun 25, 2018 at 01:31:29PM +0200, Jerome Brunet wrote: > > > > > > > Same comment as on IRC, you driver looks very similar to the one I posted a > > > > while back (sound/soc/codecs/dio2125.c) > > > > Could you just add your compatible to the list in the existing driver ? > > > > Is there anything I missed which makes them incompatible ? > > > > > > It's probably a good idea to rename that driver so it's a bit more > > > discoverable - you're absolutely right that it's very similar and doing > > > basically the same thing but I'd completely forgotten that it existed :/ > > > > Agreed , the name is poorly chosen. I did not thought it was a generic need at > > the time. > > > > Nicolò, do you want to do the remame ? or would you prefer me to do it ? > > > > Cheers > > Jerome _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel