Hi,
On 29-12-17 03:10, Bard Liao wrote:
Some questions for you:
1) I think enabling micbias2 may be a problem on devices with a DMIC,
could this be a problem? Currently the codec driver itself contains
quirks for dmic pin-mapping, maybe we should leave micbias2 disabled
if dmic pin-mapping is specified through a quirk?
No, micbias2 and DMIC are independent and micbias2 will not be enabled
if we don't add it in the audio route. So I don't think we need to disable it
if dmic pin-mapping is specified.
Right, but currently we use the "Int Mic" switch in both the DMIC and analog
mic paths, and the changes to the machine driver enable micbias2 when Int Mic
gets turned on. After my changes the machine driver has:
{"IN2P", NULL, "Int Mic"},
{"IN2N", NULL, "Int Mic"},
{"DMIC L1", NULL, "Int Mic"},
{"DMIC R1", NULL, "Int Mic"},
...
{"Int Mic", NULL, "micbias2"},
Since the analog mic is currently not working anyways, maybe we should
use Int Mic2 for the analog mic, so make the above:
{"IN2P", NULL, "Int Mic2"},
{"IN2N", NULL, "Int Mic2"},
{"DMIC L1", NULL, "Int Mic"},
{"DMIC R1", NULL, "Int Mic"},
...
{"Int Mic2", NULL, "micbias2"},
And then use
cset "name='Int Mic Switch2' on"
In the ucm file in the analog mic enable sequence?
This way the already working dmic support stays unchanged and the
analog mic support I'm adding does not enable micbias2 when using
dmic inputs.
?
Regards,
Hans
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
