>-----Original Message----- >From: Takashi Iwai [mailto:tiwai@xxxxxxx] >Sent: Thursday, December 21, 2017 10:15 PM >To: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx> >Cc: Mark Brown <broonie@xxxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx; Koul, >Vinod <vinod.koul@xxxxxxxxx>; pierre-louis.bossart@xxxxxxxxxxxxxxx; >liam.r.girdwood@xxxxxxxxxxxxxxx; Patches Audio <patches.audio@xxxxxxxxx> >Subject: Re: [RFC v3 06/11] ASoC: hdac_hda: add ASoC based >HDA codec driver > >> >> I think I am wrong in doing the above. I was thinking that I cannot do >> all those steps done in the probe before the snd_soc_codec probe gets >> called. >> >> After looking at the code again after your comments, It looks like >> I can call all these before the card is registered by the machine driver. >> >> Is that right understanding ? same thing is happening in legacy >> driver also. The card is registered at the end. So I will just skip that step. > >Well, I'm not 100% sure about the ordering, so we just need trying. > Hi Takashi, I tried various things, but I could not unify the probe of the legacy hda codec driver and the asoc library probe, mainly because all the APIs in the legacy hda codec drivers require "snd_card" pointer, which is getting allocated by the machine driver when the machine driver is loaded. So except the regmap init I could not do anything in the legacy probe. So for now I have kept them completely separate but I can do regmap init when the bus type is EXT. Regards, Rakesh _______________________________________________ Alsa-devel mailing list Alsa-devel@xxxxxxxxxxxxxxxx http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
