Re: [RFC 01/10] ASoC: Intel: Boards: Machine driver for Intel platforms

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/7/17 6:27 AM, Ughreja, Rakesh A wrote:


-----Original Message-----
From: Koul, Vinod
Sent: Wednesday, December 6, 2017 9:48 PM
To: Pierre-Louis Bossart <pierre-louis.bossart@xxxxxxxxxxxxxxx>
Cc: Ughreja, Rakesh A <rakesh.a.ughreja@xxxxxxxxx>; alsa-devel@xxxxxxxxxxxxxxxx;
broonie@xxxxxxxxxx; tiwai@xxxxxxx; liam.r.girdwood@xxxxxxxxxxxxxxx; Patches
Audio <patches.audio@xxxxxxxxx>
Subject: Re:  [RFC 01/10] ASoC: Intel: Boards: Machine driver for Intel
platforms

On Mon, Dec 04, 2017 at 09:37:37AM -0600, Pierre-Louis Bossart wrote:
On 12/4/17 9:10 AM, Ughreja, Rakesh A wrote:

    sound/soc/intel/boards/Kconfig           |  10 ++
    sound/soc/intel/boards/Makefile          |   2 +
    sound/soc/intel/boards/skl_hda_generic.c | 276
+++++++++++++++++++++++++++++++

can we drop the Skylake reference? It's become a catch-all term to mean
both the platform, the IP and the driver.

Suggest some name. I have no problem.

HiFi3 ?
iDisp ?
HDAudio-DSP ?

hda_dsp_generic.c -- For the main file
hda_dsp_common.c -- for common functions

Does it look fine ?

works for me.

Sorry not for me. hda_dsp_xxx doesnt tie it to anything. HDA and DSP are too
generic terms. But yes I don't have a better alternate than skl_generic.
Here this solution is tied to a very specfic IP which is present in SKL
onwards platforms..

Yes SKL is become an IP as well as platform. Maybe we should have a codename
for this like azx :)

We do have a code name "sst".

So does this sound okay for you ?

sst_hda_dsp_generic.c -- For main file
sst_hda_dsp_common.c -- for common functions

SST is also aliased to platform drivers with closed-source firmware, not a good idea for machine drivers.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux