Re: [PATCH v2] ASoC: wm8741: Add digital mute callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am 30.10.2017 um 16:41 schrieb Charles Keepax:
On Mon, Oct 30, 2017 at 09:28:16AM +0100, Sergej Sawazki wrote:
Signed-off-by: Sergej Sawazki <sergej@xxxxxxxxxx>
---
Changes in v2:
  * Refactored debug message.

  sound/soc/codecs/wm8741.c | 12 ++++++++++++
  1 file changed, 12 insertions(+)

diff --git a/sound/soc/codecs/wm8741.c b/sound/soc/codecs/wm8741.c
index b8c1940..5571882 100644
--- a/sound/soc/codecs/wm8741.c
+++ b/sound/soc/codecs/wm8741.c
@@ -351,6 +351,17 @@ static int wm8741_set_dai_fmt(struct snd_soc_dai *codec_dai,
  	return 0;
  }
+int wm8741_mute(struct snd_soc_dai *codec_dai, int mute)
+{
+	struct snd_soc_codec *codec = codec_dai->codec;
+
+	dev_dbg(codec->dev, "wm8741_mute:    mute = %d\n", mute);

It is still not really normal style to include the function name
in the debug messages. How about just "digital mute = %d\n" or
something like that?


Maybe not really normal, but CONSISTENT. That's the style used
throughout the entire file. And it makes the log look consistent.
_______________________________________________
Alsa-devel mailing list
Alsa-devel@xxxxxxxxxxxxxxxx
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel



[Index of Archives]     [ALSA User]     [Linux Audio Users]     [Kernel Archive]     [Asterisk PBX]     [Photo Sharing]     [Linux Sound]     [Video 4 Linux]     [Gimp]     [Yosemite News]

  Powered by Linux